Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable wxWebView in wxGTK32. #268348

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Enable wxWebView in wxGTK32. #268348

merged 1 commit into from
Nov 22, 2023

Conversation

c4lliope
Copy link

Closes #267712

Needed as a dependency for a number of language-specific packages, including https://hexdocs.pm/desktop in Elixir.

Description of changes

Enables wxWebView, based on Webkit, in GTK's wxWidgets package.
Prior to this, the web view had only been enabled in OS X.

Checked using the flake in #267712; ran ./result/bin/iex -e ':wx.demo'

Screenshot from 2023-11-15 12-40-40
Screenshot from 2023-11-16 01-15-33

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • (nonfeasible on local) Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD".
  • Tested basic functionality of all some binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 18, 2023
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 18, 2023
@ofborg ofborg bot requested a review from tfmoraes November 18, 2023 19:34
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Nov 18, 2023
@c4lliope
Copy link
Author

CC @happysalada

@happysalada
Copy link
Contributor

This looks good to me, leaving this open longer to give enough time to the maintainer to see this.

@happysalada
Copy link
Contributor

@c4lliope could you rebase when you have a moment ? I'm not sure why ofborg eval is failing.

@ofborg eval

Enable wxWebView in wxGTK32.
3c5c4b6 
Closes NixOS#267712

Needed as a dependency for a number of language-specific packages,
including https://hexdocs.pm/desktop in Elixir.
@c4lliope
Copy link
Author

Rebased. I did so this morning also to bypass a changelog collision. Hope this rebase succeeds then.

@happysalada happysalada merged commit e6fc0a2 into NixOS:master Nov 22, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfmoraes tfmoraes Awaiting requested review from tfmoraes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elixir / erlang OTP : enable wxWebView
3 participants
@c4lliope @happysalada @NixOSInfra